Skip to content

fix: Replace acplt.org with example.org in example data (#460)#474

Merged
s-heppner merged 2 commits into
eclipse-basyx:developfrom
ArokyaMatthew:fix/remove-acplt-org-references
Apr 23, 2026
Merged

fix: Replace acplt.org with example.org in example data (#460)#474
s-heppner merged 2 commits into
eclipse-basyx:developfrom
ArokyaMatthew:fix/remove-acplt-org-references

Conversation

@ArokyaMatthew

@ArokyaMatthew ArokyaMatthew commented Mar 12, 2026

Copy link
Copy Markdown

Replaces all references to https://acplt.org/ and http://acplt.org/ with https://example.org/ and http://example.org/ respectively throughout the codebase.

Closes #460

All Changes i have done -

  • 1,505 replacements across 43 text files
  • 2 regenerated .aasx binary packages (test_demo_full_example_json.aasx, test_demo_full_example_xml.aasx)

Affected areas

Category Files
Example data generators (sdk/basyx/aas/examples/data/) 5
Tutorials (sdk/basyx/aas/examples/) 4
SDK test files (sdk/test/) 14
SDK adapter docstrings & docs 3
Compliance tool source & tests 4
Compliance tool serialized fixtures (JSON/XML) 11
Compliance tool .aasx binary packages 2

I did not change-

  • URL path suffixes (e.g., /Test_Submodel, /Properties/ExampleProperty) are preserved as-is
  • URL schemes (http:// vs https://) are preserved as-is
  • No functional/logic changes — this is a pure identifier rename

Ouputs:-

image image image

@ArokyaMatthew ArokyaMatthew force-pushed the fix/remove-acplt-org-references branch from eadbdb2 to 23d2baa Compare March 12, 2026 17:01
s-heppner
s-heppner approved these changes Apr 14, 2026
View reviewed changes

@s-heppner s-heppner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!
Please excuse the late review, I was out of office.

@s-heppner

s-heppner commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Ah, could you change the target branch to develop please? We do not push to main directly, your changes will be included in the next release.

@ArokyaMatthew ArokyaMatthew changed the base branch from main to develop April 17, 2026 01:14
@ArokyaMatthew

ArokyaMatthew commented Apr 17, 2026

Copy link
Copy Markdown
Author

@s-heppner , I have changed my branch from main to develop, and next time I will make sure that I will merge my PR there.

@s-heppner

s-heppner commented Apr 20, 2026

Copy link
Copy Markdown
Member

Thank you! Could you resolve the conflicts on this branch now?
The logic should be relatively simple: Take every change from develop and replace the URL there as well, if it appears.

@ArokyaMatthew ArokyaMatthew force-pushed the fix/remove-acplt-org-references branch from 23d2baa to 905f6ca Compare April 20, 2026 16:51
@ArokyaMatthew

ArokyaMatthew commented Apr 20, 2026

Copy link
Copy Markdown
Author

@s-heppner Done! I've rebased onto the latest develop and resolved all the conflicts. The renamed APIs (object_store → identifiable_store, etc.) and the removed OpenAPI YAML files from #477 are all handled. Also caught and replaced 2 new acplt.org references that were introduced in develop since my original commit.

All tests pass locally (213 SDK + 30 compliance tool).

@s-heppner

s-heppner commented Apr 21, 2026

Copy link
Copy Markdown
Member

Alright, we're almost there!
The remaining two failing checks are pretty simple to solve:

  • repository-check-copyright: Whenever someone edits a file, we need to update the year in the copyright notice at the top of the file. Since you touched these files, you need to update the notices:
Error: Copyright year mismatch in file compliance_tool/test/test_compliance_check_aasx.py. Expected 2026, found 2025.
Error: Copyright year mismatch in file compliance_tool/test/test_compliance_check_json.py. Expected 2026, found 2025.
Error: Copyright year mismatch in file compliance_tool/test/test_compliance_check_xml.py. Expected 2026, found 2025.
Error: Copyright year mismatch in file sdk/test/examples/test_helpers.py. Expected 2026, found 2025.
Error: Copyright year mismatch in file sdk/test/model/test_aas.py. Expected 2026, found 2025.
Error: Copyright year mismatch in file sdk/test/model/test_submodel.py. Expected 2026, found 2025.
  • sdk-static-analysis: Here it seems some lines are now too long and need to be broken into several lines:
basyx/aas/examples/data/example_aas.py:614:121: E501 line too long (121 > 120 characters)
basyx/aas/examples/data/example_aas.py:656:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_aas.py:846:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_aas.py:850:121: E501 line too long (121 > 120 characters)
basyx/aas/examples/data/example_aas.py:854:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_aas_mandatory_attributes.py:109:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_aas_missing_attributes.py:244:121: E501 line too long (121 > 120 characters)
basyx/aas/examples/data/example_aas_missing_attributes.py:377:121: E501 line too long (121 > 120 characters)
basyx/aas/examples/data/example_submodel_template.py:193:121: E501 line too long (121 > 120 characters)
basyx/aas/examples/data/example_submodel_template.py:223:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_submodel_template.py:281:121: E501 line too long (122 > 120 characters)
basyx/aas/examples/data/example_submodel_template.py:298:121: E501 line too long (122 > 120 characters)
test/adapter/xml/test_xml_serialization.py:64:121: E501 line too long (121 > 120 characters)

@ArokyaMatthew

ArokyaMatthew commented Apr 22, 2026

Copy link
Copy Markdown
Author

Hey @s-heppner, thanks for the review! I've addressed both failing checks:
Copyright years: Updated all 6 files to 2026.
Line length: Fixed all E501 violations by splitting the long URL strings using implicit string concatenation. Also cleaned up a couple of E127 indentation issues that came out of the line breaks.
Everything passes pycodestyle --max-line-length=120 cleanly now.

s-heppner
s-heppner approved these changes Apr 23, 2026
View reviewed changes

@s-heppner s-heppner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thank you!

@s-heppner s-heppner merged commit a53e228 into eclipse-basyx:develop Apr 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s-heppner s-heppner s-heppner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove references of https://acplt.org/ from example data

2 participants

@ArokyaMatthew @s-heppner